-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
280 add documentdb interoperability #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentdb-interoperability
Ran `npm-check-updates -u` to bump all dependencies. Explicitly installed mongoose@7x. Per the Mongoose documentation, we must upgrade to 7x before we can upgrade to 8x.
This is a preemptive change for Mongoose 8x. In Mongoose 7, findOneAndRemove() was an alias for findOneAndDelete() that Mongoose supported for backwards compatibility. Mongoose 8 no longer supports findOneAndRemove(). Use findOneAndDelete() instead.
seansica
approved these changes
Jan 10, 2025
The .eslintrc.yml style configuration is no longer supported in ESLint 9x. Migrated to eslint.config.js JavaScript based config. This upgrade obfuscates many in-line eslint directives that were previously in use. In particular, there were a lot of 'no-await-in-loop' disable directives that can be/have been removed.
Resolves no-unused-vars linting error
- Refactoring into a sub-package to break up the code into smaller modules - Replacing all callbacks with promises - Breaking up code chunks into functions that are easier to read - Consolidating shared components in bundle-helper module
This function was previously defined and called within the collection-bundles.service. It is now split into two functions: - addNotes: available in the service layer - retrieveAllActiveNotes: available in the repository layer All functionality is the same.
- nanoid: 5x --> 3x - openid-client: 6x --> 5x - mongoose: 7x --> 6x Both of these dependencies have moved to ESM in their latest respective revision, meaning that we can no longer import them using the standard CommonJS syntax. NanoID outlines a solution involving dynamic imports. Luckily nanoid@3 is still actively supported, so this change will be handled in a future revision. All regression tests are passing.
…tead of callbacks
We can remove the old collection-bundles-service.js module now that its been refactored into a sub-package (See: services/collection-bundles-service/index.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of $facet and $count aggregation pipeline operators, which are unsupported in Amazon DocumentDB.